chaas/debshots
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Remove the temporary show=libs inspection view

Browse source 
The libs-section blacklist is confirmed safe; the review view has
served its purpose.
This commit is contained in:
Christoph Haas 2026-08-23 14:13:53 +02:00
parent a98398f7a1
commit 07be9eadcc
2 changed files with 0 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

5
app/controllers/packages_controller.rb
View file

@ -381,11 +381,6 @@ class PackagesController < ApplicationController
when 'without'
packages = packages.without_screenshots
logger.debug 'Limiting packages to those without screenshots'
when 'libs'
# Temporary inspection view: exactly the screenshot-bearing
# packages that the libs section blacklist would remove on the
# next import
packages = packages.where("section ~* '/?(old)?libs$'").with_screenshots
end
packages

12
test/controllers/packages_controller_test.rb
View file

@ -134,18 +134,6 @@ class PackagesControllerTest < ActionController::TestCase
end
end
test 'show=libs lists screenshot-bearing blacklist candidates only' do
packages(:firefox).update_column(:section, 'libs')
# vim has no screenshots in the fixtures - even in libs section it
# must not appear
packages(:vim).update_column(:section, 'libs')
get :grid, params: { show: 'libs' }
assert_response :success
assert_select 'div', text: 'firefox', count: 1
assert_select 'div', text: 'vim', count: 0
end
# test 'should get thumbnail for a package and a desired version' do
# # get '/thumbnail-with-version/package-5/0.1'
# get thumbnail_with_version_url('package-5', '0.1')