From 13218841f4c07ff87c4937ab1a92ef2ceda0506f Mon Sep 17 00:00:00 2001 From: Christoph Haas Date: Mon, 20 Apr 2015 20:33:40 +0200 Subject: [PATCH] Optimisation: only query database if the package is not obviously blacklisted Performance gain: 20x --- lib/tasks/import_debian.rake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/tasks/import_debian.rake b/lib/tasks/import_debian.rake index dfd6c63..262ca02 100644 --- a/lib/tasks/import_debian.rake +++ b/lib/tasks/import_debian.rake @@ -74,11 +74,10 @@ task :import_debian => :environment do Rails.logger.info "> Package: #{package[:Package]}" #Rails.logger.debug "Fetching package informaton from the database" - db_package = Package.find_by name: package[:Package] - if package_blacklisted? package # Should the package get removed from the database? if REMOVE_BLACKLISTED_PACKAGE + db_package = Package.find_by name: package[:Package] if db_package Rails.logger.info "Removing blacklisted package '#{package[:Package]}' from database" db_package.destroy @@ -88,6 +87,7 @@ task :import_debian => :environment do next end # if blacklisted + db_package = Package.find_by name: package[:Package] unless db_package Rails.logger.debug "No such package in our database." next