Show proper filename in error messages after upload

This commit is contained in:
Christoph Haas 2020-11-12 19:35:35 +01:00
parent b921a832b4
commit 2878dbfad6

View file

@ -55,7 +55,7 @@ class PackagesController < ApplicationController
params[:file].each do |img|
# Log.log "Uploaded img=#{img.path}"
new_screenshot = @package.screenshots.new(simage: img)
# BUG: ActiveStorage will accept the broken PNG during upload!
# Check if the image was valid
@ -79,18 +79,17 @@ class PackagesController < ApplicationController
new_screenshot.save!
Log.log "Screenshot #{new_screenshot.id} uploaded successfully. ip=#{session[:ip]}. user-token=#{session[:token]}. user-name=#{current_user}"
@valid_images.push new_screenshot
else
Log.log "Screenshot #{new_screenshot.image_file_name} invalid (#{new_screenshot.errors[:image]})."
@invalid_images.push new_screenshot
@invalid_images.push new_screenshot.original_filename
end
end
errors = []
@invalid_images.each do |image|
# errors << "The image #{image.image_file_name} #{image.errors[:image].join(' and ')}."
errors << "That file #{image.image_file_name} is not valid."
errors << "The file #{image} is not valid."
flash[:error] = errors.join(" ")
end