From 2d53397ddabbff3f7f94df0c655e15a3439d3e71 Mon Sep 17 00:00:00 2001 From: Christoph Haas Date: Fri, 30 Oct 2020 21:53:26 +0100 Subject: [PATCH] Bug hint added Asked on Stackoverflow: https://stackoverflow.com/questions/64615529/how-can-i-avoid-accepting-broken-images-in-activestorage --- app/controllers/packages_controller.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/controllers/packages_controller.rb b/app/controllers/packages_controller.rb index 045bada..d4ef66c 100644 --- a/app/controllers/packages_controller.rb +++ b/app/controllers/packages_controller.rb @@ -62,6 +62,8 @@ class PackagesController < ApplicationController # Log.log "Uploaded img=#{img.path}" new_screenshot = @package.screenshots.new(image: img) + # BUG: ActiveStorage will accept the broken PNG during upload! + # Check if the image was valid if new_screenshot.valid? new_screenshot.uploaderhash = session.id.to_s @@ -77,7 +79,7 @@ class PackagesController < ApplicationController new_screenshot.approve! if auto_approve? end - new_screenshot.save + new_screenshot.save! Log.log "Screenshot #{new_screenshot.id} uploaded successfully. ip=#{session[:ip]}. user-token=#{session[:token]}. user-name=#{current_user}" @valid_images.push new_screenshot