Moved Screenshot.adminstatus to status_text helper

This change allows the use of fa_icon helpers

app/helpers/packages_helper.rb

@@ -58,4 +58,16 @@ module PackagesHelper
   #   empty_stars = fa_icon('star-o') * (5-rating)
   #   (filled_stars+empty_stars).html_safe
   # end
+
+  def status_text(screenshot)
+    # TODO: markedfordelete/reporting will be removed
+    if screenshot.markedfordelete
+      "Removal requested > #{screenshot.delete_reason}"
+    elsif screenshot.approved
+      fa_icon('check-square') + ' Public'
+    else
+      fa_icon('hourglass') + ' Waiting for approval'
+    end
+  end
+
 end

app/models/screenshot.rb

@@ -71,15 +71,15 @@ class Screenshot < ApplicationRecord
   end
 
   # Brief text describing the status of this screenshots (for admins)
-  def adminstatus
+  # def adminstatus
-    if self.markedfordelete
+  #   if self.markedfordelete
-      "Removal requested > #{self.delete_reason}"
+  #     "Removal requested > #{self.delete_reason}"
-    elsif self.approved
+  #   elsif self.approved
-      'Public'
+  #     'Public'
-    else
+  #   else
-      'Waiting for approval'
+  #     fa_icon('hourglass') + 'Waiting for approval'
-    end
+  #   end
-  end
+  # end
 
   # Publish a screenshot from the moderation queue
   def approve!

app/views/packages/details.slim

@@ -34,8 +34,7 @@
                     hr
                     .text
                       span.label.secondary
-                        ' Status:
+                        = status_text(screenshot)
-                        = screenshot.adminstatus
 
                     = render(partial: 'admin_buttons', locals: {screenshot: screenshot})
                   / - elsif user_signed_in? and screenshot.user == current_user