From 527bc7cd07bd54b79bff07c6489c511f7f8e4fcc Mon Sep 17 00:00:00 2001 From: Christoph Haas Date: Wed, 19 Apr 2017 21:44:54 +0200 Subject: [PATCH] Fixed display of Ubuntu reviews --- app/controllers/packages_controller.rb | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/controllers/packages_controller.rb b/app/controllers/packages_controller.rb index 16f1919..bff5dfc 100644 --- a/app/controllers/packages_controller.rb +++ b/app/controllers/packages_controller.rb @@ -200,7 +200,7 @@ class PackagesController < ApplicationController def reviews expires_in 1.day, public: true # @reviews = Package.find_by_name!(params[:name]).ubuntu_reviews - @reviews = get_ubuntu_reviews :name + @reviews = get_ubuntu_reviews params[:name] render '_reviews', layout: false end @@ -261,9 +261,12 @@ class PackagesController < ApplicationController # Get reviews of this package from the Ubuntu API def get_ubuntu_reviews(packagename) # Use the URL defined in the configuration to get a JSON string - json = open(Rails.configuration.ubuntu_reviews_api_url % packagename).read + url = Rails.configuration.ubuntu_reviews_api_url % packagename + logger.debug "Loading Ubuntu reviews for package #{packagename} from #{url}" + + body = open(url).read # Turn JSON into a Ruby data structure - json = JSON.parse(json) + json = JSON.parse(body) # Only show english reviews # TODO: Support further languages json = json.select {|x| x['language']=='en'}