From 5d856c61e6f9716eee0273ac7a9eef4e448f2e6b Mon Sep 17 00:00:00 2001 From: Christoph Haas Date: Thu, 16 Jun 2016 10:42:04 +0200 Subject: [PATCH] Properly return a 404 if an existing package has no screenshot --- app/controllers/packages_controller.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/controllers/packages_controller.rb b/app/controllers/packages_controller.rb index f077f9a..688fcf8 100644 --- a/app/controllers/packages_controller.rb +++ b/app/controllers/packages_controller.rb @@ -82,7 +82,9 @@ class PackagesController < ApplicationController return end @screenshot = @package.screenshots.first - unless @screenshot.image.path + + # Return a 404 if the package has no screenshots or the image was not found + unless @screenshot or @screenshot.image.path thumbnail404 return end