From 78b8f594af23fe3cc9840351041194b4f9bcd03e Mon Sep 17 00:00:00 2001 From: Christoph Haas Date: Wed, 7 Aug 2013 21:37:14 +0200 Subject: [PATCH] Enforce eager loading of backreferencing to avoid wasteful SQL queries --- app/models/package.rb | 2 +- app/models/screenshot.rb | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/app/models/package.rb b/app/models/package.rb index 824258e..3662f02 100644 --- a/app/models/package.rb +++ b/app/models/package.rb @@ -1,3 +1,3 @@ class Package < ActiveRecord::Base - has_many :screenshots + has_many :screenshots, :inverse_of=>:package end diff --git a/app/models/screenshot.rb b/app/models/screenshot.rb index 26e2a00..1e8c0e2 100644 --- a/app/models/screenshot.rb +++ b/app/models/screenshot.rb @@ -1,10 +1,6 @@ class Screenshot < ActiveRecord::Base - belongs_to :package + belongs_to :package, :inverse_of=>:screenshots - # Return the URL to this screenshot. - # size: 'small' (thumbnail) or 'large' (full-size) - # (If possible serve the screenshots statically from the web server.) - #attr_accessor :image_url def image_url(size) # TODO: Prevents proper eager loading somehow... "/screenshots/#{self.package.name[0]}/#{self.package.name}/#{self.id}_#{size}.png"