diff --git a/app/controllers/packages_controller.rb b/app/controllers/packages_controller.rb index 4afec52..23c24f8 100644 --- a/app/controllers/packages_controller.rb +++ b/app/controllers/packages_controller.rb @@ -55,6 +55,8 @@ class PackagesController < ApplicationController @package = Package.find_by(name: params[:name]) params[:screenshot][:image].each do |img| @package.screenshots.create(image: img) + # TODO: add logging + # TODO: what do we do if the user uploads an invalid image? tell them? end redirect_to package_path diff --git a/app/models/screenshot.rb b/app/models/screenshot.rb index 17d42e0..b32d4d9 100644 --- a/app/models/screenshot.rb +++ b/app/models/screenshot.rb @@ -11,6 +11,8 @@ class Screenshot < ActiveRecord::Base #path: ':rails_root/public/system/:class/:attachment/:id_partition/:style/:filename', path: ':rails_root/public/screenshots/:id_partition/:style.png', url: '/screenshots/:id_partition/:style.png', + # TODO: Make hash_secret configurable in the main configuration. + # Do not check it into Git. hash_secret: 'M4xGM9v6y17Y27sZ1liWrnQaXdX4YDdZCJ7fOqcAUg3cZJqK9x' validates_attachment_content_type :image, :content_type => /\Aimage\/png\Z/