chaas/debshots
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Syntax fix for screenshot variants in ActiveStorage

Browse source
This commit is contained in:
Christoph Haas 2020-08-21 19:12:10 +02:00
parent 771ca41240
commit 879ddcfa69
6 changed files with 14 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/views/packages/_grid_thumbnail.slim
View file

@ -4,7 +4,7 @@ a.black href=package_path(name: pkg.name)
- if pkg.screenshots_approved.any?
// TODO: smarter selection of the most useful screenshot instead of taking the first one
- screenshot = pkg.screenshots.first
= image_tag(screenshot.image.variant(resize_to_limit: "160x120"), alt: screenshot.caption, class: 'thumbnail')
= image_tag(screenshot.image.variant(resize_to_limit: [160,120]), alt: screenshot.caption, class: 'thumbnail')
- else
img.screenshot.thumbnail src="/images/dummy/no-screenshots-upload-one.svg"
div

18
app/views/packages/upload.slim
View file

@ -25,20 +25,12 @@ h1 = "Upload screenshots for #{@package.name}"
= fa_stacked_icon "upload", base: "circle-thin"
' Start upload
p
- if @package.screenshots.any?
' Just for your information - these screenshots have already been uploaded.
- if @package.screenshots.any?
p Just for your information - these screenshots have already been uploaded:
.small-up-1.medium-up-3.large-up-4.grid-thumbnails
- @package.screenshots.all.each do |ss|
.column
a.black.fancybox href=rails_representation_url(ss.image.variant(resize_to_limit: "800x600")) rel='fancybox-thumb' title=ss.caption
= image_tag(ss.image.variant(resize_to_limit: "160x120"), alt: ss.caption, class: 'thumbnail')
// = render partial: 'packages/grid_thumbnail', locals: { pkg: pkg }
//- else
// ' There are no screenshots yet for #{@package.name}. Your upload will
// ' be the first.
- @package.screenshots.all.each do |ss|
a.black.fancybox href=rails_representation_url(ss.image.variant(resize_to_limit: [800,600])) rel='fancybox-thumb' title=ss.caption
= image_tag(ss.image.variant(resize_to_limit: [160,120]), alt: ss.caption, class: 'thumbnail')
.small-5.cell.bigpanel