Avoid N+1 SQL queries with CanCanCan accessibility checks

This commit is contained in:
Christoph Haas 2021-03-01 00:49:25 +01:00
parent f154c1838c
commit b36a49a6cd
6 changed files with 14 additions and 12 deletions

View file

@ -18,7 +18,7 @@
.cell.pkgcard data-equalizer-watch=true
a.black href=package_path(name: pkg.name)
.image
= small_img(pkg.screenshots.accessible_by(current_ability, :view).first, cls: '')
= small_img(pkg.screenshots.first, cls: '')
.text.pkgname
= pkg.name
.text
@ -29,7 +29,7 @@
.small-12.medium-4.cell.pkgcard
a.black href=package_path(name: pkg.name)
.image
= small_img(pkg.screenshots.accessible_by(current_ability, :view).first, cls: '')
= small_img(pkg.screenshots.first, cls: '')
.small-12.medium-8.cell
h2
a href=package_path(name: pkg.name)

View file

@ -25,7 +25,7 @@
.text
= screenshot.caption
// Has the unmoderated screenshot been uploaded by the current user?
- if current_user.screenshots.include?(screenshot)
- if current_user && current_user.screenshots.include?(screenshot)
.text
span.label.secondary
' Uploaded by you