From b57ed7ce1b526e4fddb18fca6b064e66bdb1caba Mon Sep 17 00:00:00 2001 From: Christoph Haas Date: Thu, 21 Jul 2016 18:38:44 +0200 Subject: [PATCH] Validation for screenshot reporting form fixed --- app/controllers/packages_controller.rb | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/controllers/packages_controller.rb b/app/controllers/packages_controller.rb index 559776c..d71cfdd 100644 --- a/app/controllers/packages_controller.rb +++ b/app/controllers/packages_controller.rb @@ -180,8 +180,13 @@ class PackagesController < ApplicationController if verify_recaptcha @screenshot.delete_reason = params[:delete_reason] @screenshot.markedfordelete = true - @screenshot.save! - flash['notice'] = "Screenshot reported. The moderators will deal with it." + if @screenshot.valid? + @screenshot.save! + flash['notice'] = "Screenshot reported. The moderators will deal with it." + else + errors = @screenshot.errors.to_a.join(' and ') + flash['alert'] = "Sorry. #{errors}" + end end redirect_to :back end