From f9130c69724c58f50e84caf48fff9d468988a733 Mon Sep 17 00:00:00 2001 From: Christoph Haas Date: Wed, 10 Mar 2021 01:04:43 +0100 Subject: [PATCH] Cruft --- app/models/package.rb | 16 ---------------- app/views/packages/_user_dropdown.slim | 17 ----------------- 2 files changed, 33 deletions(-) delete mode 100644 app/views/packages/_user_dropdown.slim diff --git a/app/models/package.rb b/app/models/package.rb index d494d51..bdfa283 100644 --- a/app/models/package.rb +++ b/app/models/package.rb @@ -56,7 +56,6 @@ class Package < ApplicationRecord Package.joins(:screenshots).where('screenshots.approved=false').distinct(:name) end - # Return a query of all packages that do not have screenshots def self.without_screenshots # Query for all packages who's ID does not appear in a screenshot's "package_id" field @@ -64,21 +63,6 @@ class Package < ApplicationRecord where.not(id: subselect) end - # Return a query of all approved/public screenshots of this package - def screenshots_approved - self.screenshots.where(approved: true) - end - - # Return a query of all approved/public screenshots of this package - def screenshots_pending - self.screenshots.where(approved: false) - end - - # Return a list of packages that have unapproved screenshots - def self.requiring_moderation - self.joins(:screenshots).where(screenshots: {approved:false}).distinct(:name) - end - # Get all screenshots and have them sorted descendingly by their version number (Debian style). def screenshots_sorted_by_version self.screenshots.to_a.sort { |x,y| version_compare(x.version,y.version) } diff --git a/app/views/packages/_user_dropdown.slim b/app/views/packages/_user_dropdown.slim deleted file mode 100644 index baf2003..0000000 --- a/app/views/packages/_user_dropdown.slim +++ /dev/null @@ -1,17 +0,0 @@ -/ Ask the user to add a description if not yet done -- if screenshot.description.blank? - / TODO: Allow the user to edit the screenshot's description again? - div - = form_for screenshot, url: update_screenshot_description_path(screenshot) do |f| - label for='description' Please add a short description of this screenshot: - .input-group - span.input-group-label = fa_icon 'edit wobble' - = f.text_field 'description', class: 'input-group-field', maxlength: 80 - .input-group-button - = f.submit 'Save', class: 'button success' - -/ Offer to delete the screenshot -a.button.small.alert[ - href=delete_screenshot_path(screenshot.id) - onclick="return confirm('Really delete your screenshot again?');" - ] Delete your screenshot