Add backend validation for aliases

- Validate source email format (RFC 5321 local-part)
- Ensure source is in the correct domain
- Validate destination (single or comma-separated emails)
- Check for duplicate aliases
- Add GetAliasBySource database method
This commit is contained in:
Christoph Haas 2026-03-24 21:57:32 +01:00
parent 25a3eae628
commit 53261dec0c
2 changed files with 45 additions and 0 deletions

View file

@ -3,6 +3,7 @@ package handlers
import (
"net/http"
"strconv"
"strings"
"github.com/gin-gonic/gin"
"github.com/imc-vibe/backend/internal/db"
@ -86,6 +87,42 @@ func (h *AliasHandler) Create(c *gin.Context) {
return
}
// Validate source email format
if err := validateEmailLocalPart(req.Source); err != nil {
Error(c, http.StatusBadRequest, "source "+err.Error())
return
}
// Ensure source is in the correct domain
if !strings.HasSuffix(req.Source, "@"+domainName) {
Error(c, http.StatusBadRequest, "source must be in domain "+domainName)
return
}
// Validate destination - can be single email or comma-separated list
destinations := strings.Split(req.Destination, ",")
for _, dest := range destinations {
dest = strings.TrimSpace(dest)
if dest == "" {
Error(c, http.StatusBadRequest, "destination cannot be empty")
return
}
// Destination doesn't need @domain validation since it can be external
if strings.Contains(dest, "@") {
if err := validateEmailLocalPart(dest); err != nil {
Error(c, http.StatusBadRequest, "destination "+err.Error())
return
}
}
}
// Check for duplicate alias
existing, _ := h.db.GetAliasBySource(req.Source)
if existing != nil {
Error(c, http.StatusConflict, "alias already exists")
return
}
alias, err := h.db.CreateAliasInDomain(req.Source, req.Destination, domain.ID)
if err != nil {
Error(c, http.StatusInternalServerError, "failed to create alias")

View file

@ -42,6 +42,14 @@ func (d *DB) GetAliasByID(id uint) (*Alias, error) {
return &alias, nil
}
func (d *DB) GetAliasBySource(source string) (*Alias, error) {
var alias Alias
if err := d.Where("source = ?", source).First(&alias).Error; err != nil {
return nil, err
}
return &alias, nil
}
func (d *DB) CreateAlias(source, destination string) (*Alias, error) {
alias := Alias{
Source: source,