Use native HTML <dialog> element for modals

Replaced CSS-based modal with native HTML <dialog> element.
Cleaner code, better accessibility, built-in backdrop handling.
This commit is contained in:
Christoph Haas 2026-03-22 23:56:56 +01:00
parent a8aaa08d29
commit 5c3e4ce7d8

View file

@ -16,7 +16,7 @@
let domains = $state<Domain[]>([]);
let user = $state<UserInfo | null>(null);
let loading = $state(true);
let showModal = $state(false);
let dialogEl = $state<HTMLDialogElement | null>(null);
let newDomain = $state({ name: '' });
let createError = $state('');
@ -48,6 +48,16 @@
}
}
function openModal() {
createError = '';
newDomain = { name: '' };
dialogEl?.showModal();
}
function closeModal() {
dialogEl?.close();
}
async function createDomain() {
createError = '';
try {
@ -58,8 +68,7 @@
});
const data = await res.json();
if (res.ok) {
showModal = false;
newDomain = { name: '' };
closeModal();
await loadData();
} else {
createError = data.error || 'Failed to create domain';
@ -93,7 +102,7 @@
<div class="header">
<h2>Domains</h2>
{#if isAdmin()}
<button onclick={() => showModal = true}>Add Domain</button>
<button onclick={openModal}>Add Domain</button>
{/if}
</div>
@ -139,25 +148,22 @@
</table>
{/if}
{#if showModal}
<button class="modal-backdrop" onclick={() => { showModal = false; createError = ''; }} aria-label="Close modal"></button>
<div class="modal">
<h3>Add Domain</h3>
<form onsubmit={(e) => { e.preventDefault(); createDomain(); }}>
<label>
Domain name:
<input type="text" bind:value={newDomain.name} placeholder="example.org" required />
</label>
{#if createError}
<p class="error">{createError}</p>
{/if}
<div class="actions">
<button type="button" onclick={() => { showModal = false; createError = ''; }}>Cancel</button>
<button type="submit">Create</button>
</div>
</form>
</div>
{/if}
<dialog bind:this={dialogEl}>
<h3>Add Domain</h3>
<form onsubmit={(e) => { e.preventDefault(); createDomain(); }}>
<label>
Domain name:
<input type="text" bind:value={newDomain.name} placeholder="example.org" required />
</label>
{#if createError}
<p class="error">{createError}</p>
{/if}
<div class="actions">
<button type="button" class="secondary" onclick={closeModal}>Cancel</button>
<button type="submit">Create</button>
</div>
</form>
</dialog>
<style>
.header {
@ -236,54 +242,48 @@
color: white;
}
button.secondary {
background: #95a5a6;
}
button.danger {
background: #e74c3c;
}
.modal-backdrop {
position: fixed;
inset: 0;
background: rgba(0,0,0,0.5);
border: none;
cursor: pointer;
z-index: 100;
}
.modal {
position: fixed;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
background: white;
dialog {
padding: 2rem;
border-radius: 8px;
min-width: 400px;
z-index: 101;
border: none;
box-shadow: 0 4px 20px rgba(0,0,0,0.2);
}
.modal h3 {
margin-top: 0;
dialog::backdrop {
background: rgba(0,0,0,0.5);
}
.modal form {
dialog h3 {
margin: 0 0 1rem 0;
}
dialog form {
display: flex;
flex-direction: column;
gap: 1rem;
}
.modal label {
dialog label {
display: flex;
flex-direction: column;
gap: 0.5rem;
}
.modal input {
dialog input {
padding: 0.5rem;
border: 1px solid #ddd;
border-radius: 4px;
}
.modal .error {
dialog .error {
color: #e74c3c;
background: #fdecea;
padding: 0.5rem;