chaas/debshots
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Bug hint added

Browse source 
Asked on Stackoverflow:
https://stackoverflow.com/questions/64615529/how-can-i-avoid-accepting-broken-images-in-activestorage
This commit is contained in:
Christoph Haas 2020-10-30 21:53:26 +01:00
parent 8b11a77817
commit 2d53397dda
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/packages_controller.rb
View file

@ -62,6 +62,8 @@ class PackagesController < ApplicationController
# Log.log "Uploaded img=#{img.path}" # Log.log "Uploaded img=#{img.path}"
new_screenshot = @package.screenshots.new(image: img) new_screenshot = @package.screenshots.new(image: img)
# BUG: ActiveStorage will accept the broken PNG during upload!
# Check if the image was valid # Check if the image was valid
if new_screenshot.valid? if new_screenshot.valid?
new_screenshot.uploaderhash = session.id.to_s new_screenshot.uploaderhash = session.id.to_s
@ -77,7 +79,7 @@ class PackagesController < ApplicationController
new_screenshot.approve! if auto_approve? new_screenshot.approve! if auto_approve?
end end
new_screenshot.save new_screenshot.save!
Log.log "Screenshot #{new_screenshot.id} uploaded successfully. ip=#{session[:ip]}. user-token=#{session[:token]}. user-name=#{current_user}" Log.log "Screenshot #{new_screenshot.id} uploaded successfully. ip=#{session[:ip]}. user-token=#{session[:token]}. user-name=#{current_user}"
@valid_images.push new_screenshot @valid_images.push new_screenshot